[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH trivial] vl: Avoid to close stdout after finish
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH trivial] vl: Avoid to close stdout after finish 'writeconfig' option |
Date: |
Tue, 22 Apr 2014 20:18:34 +0100 |
On 22 April 2014 17:31, Eric Blake <address@hidden> wrote:
> Hmm, maybe we should update the qemu wiki?
> http://wiki.qemu.org/Contribute/SubmitAPatch doesn't mention the qemu
> preferred style (you pointed to the GNOME style, but at least GNU
> coreutils explicitly prefers lowercase).
>
> At any rate, I'm not going to reject a patch based on capitalization,
Yeah, it doesn't really seem worth trying to enforce niceties
of style here -- the effort required doesn't seem to really match
the benefit, and we already have a lot of hoops we make new
submitters jump through. "[file or area being patched]: [reasonably
descriptive short summary]" is about the limit I personally feel
comfortable insisting on.
thanks
-- PMM