Re: [Qemu-devel] [PATCH V3 0/5] remove QEMUMachine indirection from MachineClass

[Marcel Apfelbaum]

On Wed, 2014-04-09 at 20:34 +0300, Marcel Apfelbaum wrote:
> Cc: Andreas Färber <address@hidden>
> 
> V2 -> V3:
>   - Addressed Andreas's comments:
>     - Dropped QEMUMachineInitArgs's 'next' obsoleted field
>       in a separate patch
>     - Revision the separation into patches:
>       - Started using MachineClass for .machine early (3/5).
>       - Merged hw/ppc changes with QEMUMachine indirection removal
>       - Ensured that git bisect is not affected
>   - Rebased to master.

Ping

Thanks,
Marcel

>     
> V1 -> V2:
>   - Addressed Paolo's comments:
>     - replaced commas by semicolons on patch 4/5.
>   - Rebased to master.
> 
> This is a continuation of 'QEMU Machine as QOM object' effort.
> The scope of this series is to allow machine QOM-ification
> of all machines gradually, by removing the need for QEMUMachine registration 
> through vl.c .
> 
> Now we will have 2 paths:
> 1. Non QOM-ified machines will be converted to QOM on the fly
>    in vl.c by qemu machine registration.
> 2. QOM-ified machines will behave as regular QOM classes setting
>    MachineClass fields in class_init.
>    - Patch 4/5 demonstrates this.
> 
> Next steps:
>  - Replace QemuOpts queries by MachineState fields.
>  - Follow Paolo's suggestions to get rid of QEMUMachineInitArgs.
> 
> Comments are appreciated,
> 
> Thanks,
> Marcel
> 
> Marcel Apfelbaum (5):
>   hw/boards.h: remove obsoleted field from QEMUMachine
>   vl.c: copy QEMUMachine's fields to MachineClass
>   vl.c: Replace QEMUMachine with MachineClass in QEMUMachineInitArgs
>   machine: replace QEMUMachine by MachineClass in accelerator
>     configuration
>   machine: remove QEMUMachine indirection from MachineClass
> 
>  device-hotplug.c        |   2 +-
>  hw/ppc/spapr.c          |  26 +++++------
>  include/hw/boards.h     |  30 +++++++++++--
>  include/hw/xen/xen.h    |   2 +-
>  include/qemu/typedefs.h |   1 +
>  include/sysemu/kvm.h    |   2 +-
>  include/sysemu/qtest.h  |   2 +-
>  kvm-all.c               |   6 +--
>  kvm-stub.c              |   2 +-
>  qmp.c                   |   4 +-
>  qtest.c                 |   2 +-
>  vl.c                    | 114 
> +++++++++++++++++++++++++++---------------------
>  xen-all.c               |   2 +-
>  xen-stub.c              |   2 +-
>  14 files changed, 116 insertions(+), 81 deletions(-)
>