[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] qemu-img: Consistently name Error * objects
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] qemu-img: Consistently name Error * objects err, and not errp |
Date: |
Thu, 24 Apr 2014 12:16:53 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 24.04.2014 um 11:15 hat Markus Armbruster geschrieben:
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qemu-img.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 8455994..88124bf 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -442,12 +442,12 @@ fail:
>
> static void dump_json_image_check(ImageCheck *check, bool quiet)
> {
> - Error *errp = NULL;
> + Error *err = NULL;
> QString *str;
> QmpOutputVisitor *ov = qmp_output_visitor_new();
> QObject *obj;
> visit_type_ImageCheck(qmp_output_get_visitor(ov),
> - &check, NULL, &errp);
> + &check, NULL, &err);
> obj = qmp_output_get_qobject(ov);
> str = qobject_to_json_pretty(obj);
> assert(str != NULL);
I'd like to have my bikeshed green: Can we use local_err instead, please?
Kevin
- [Qemu-devel] [PATCH 0/5] block: Purge error_is_set(), Markus Armbruster, 2014/04/24
- [Qemu-devel] [PATCH 1/5] Use error_is_set() only when necessary (again), Markus Armbruster, 2014/04/24
- [Qemu-devel] [PATCH 3/5] nbd: Use return values instead of error_is_set(errp), Markus Armbruster, 2014/04/24
- [Qemu-devel] [PATCH 2/5] qemu-img: Consistently name Error * objects err, and not errp, Markus Armbruster, 2014/04/24
- Re: [Qemu-devel] [PATCH 2/5] qemu-img: Consistently name Error * objects err, and not errp,
Kevin Wolf <=
- [Qemu-devel] [PATCH 5/5] iscsi: Don't use error_is_set() to suppress additional errors, Markus Armbruster, 2014/04/24
- [Qemu-devel] [PATCH 4/5] blockdev: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/04/24