[Qemu-devel] [PATCH 00/15] qmp qga: Purge error_is_set()

[Markus Armbruster]

I got a private branch getting rid of it entirely.  This is the fifth
part, covering QMP and the guest agent up to the point where I start
messing with the QAPI code generators.  That's left for the final
part.

Luiz, Mike, do I need to separate off the qga bits, or can this go
through one of your trees as is?

Markus Armbruster (15):
  qmp hmp: Consistently name Error * objects err, and not errp
  qga: Consistently name Error ** objects errp, and not err
  qga: Consistently name Error ** objects errp, and not err
  qmp: Consistently name Error ** objects errp, and not err
  error: Consistently name Error ** objects errp, and not err
  qga: Use return values instead of error_is_set(errp)
  hmp: Guard against misuse of hmp_handle_error()
  qapi: Drop redundant, unclean error_is_set()
  tests/qapi-schema: Drop superfluous error_is_set()
  qapi: Clean up fragile use of error_is_set()
  qga: Clean up fragile use of error_is_set()
  qga: Drop superfluous error_is_set()
  qemu-option: Clean up fragile use of error_is_set()
  dump: Drop pointless error_is_set(), DumpState member errp
  qmp: Don't use error_is_set() to suppress additional errors

 docs/writing-qmp-commands.txt      |  28 ++---
 dump.c                             |   6 +-
 hmp.c                              | 137 ++++++++++++------------
 include/qapi/error.h               |  27 +++--
 include/qapi/qmp/dispatch.h        |   2 +-
 qapi/qmp-dispatch.c                |  24 ++---
 qga/commands-posix.c               | 213 ++++++++++++++++++++-----------------
 qga/commands-win32.c               | 123 ++++++++++-----------
 qga/commands.c                     |   4 +-
 qga/main.c                         |   1 +
 qga/vss-win32.c                    |   4 +-
 qga/vss-win32.h                    |   2 +-
 qmp.c                              |  42 +++-----
 tests/test-qmp-input-strict.c      |  72 ++++++-------
 tests/test-qmp-input-visitor.c     |  89 ++++++++--------
 tests/test-qmp-output-visitor.c    |  74 ++++++-------
 tests/test-string-input-visitor.c  |  50 ++++-----
 tests/test-string-output-visitor.c |  46 ++++----
 util/error.c                       |   8 +-
 util/qemu-option.c                 |   2 +-
 20 files changed, 482 insertions(+), 472 deletions(-)

-- 
1.8.1.4