[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of d
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs |
Date: |
Mon, 28 Apr 2014 13:05:10 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 |
28.04.2014 12:26, Marc Marí пишет:
> From: Marc Marí <address@hidden>
>
> Modify debug macros as explained in
> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
>
> Signed-off-by: Marc Marí <address@hidden>
> ---
> hw/dma/i82374.c | 17 ++++++++++-------
> hw/dma/i8257.c | 24 +++++++++++++++++-------
> hw/dma/rc4030.c | 13 +++++++++----
> 3 files changed, 36 insertions(+), 18 deletions(-)
>
> diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
> index dc7a767..fff4e6f 100644
> --- a/hw/dma/i82374.c
> +++ b/hw/dma/i82374.c
> @@ -24,15 +24,18 @@
>
> #include "hw/isa/isa.h"
>
> -//#define DEBUG_I82374
> +//#define DEBUG_I82374 1
>
> -#ifdef DEBUG_I82374
> -#define DPRINTF(fmt, ...) \
> -do { fprintf(stderr, "i82374: " fmt , ## __VA_ARGS__); } while (0)
> -#else
> -#define DPRINTF(fmt, ...) \
> -do {} while (0)
> +#ifndef DEBUG_I82374
> +#define DEBUG_I82374 0
> #endif
> +
> +#define DPRINTF(fmt, ...) \
> + do { \
> + if(DEBUG_I82374) { \
> + fprintf(stderr, "I82374: " fmt, ## __VA_ARGS__); \
> + } \
> + } while (0)
Since this is the same pattern in all files touched, it can be generalized:
qemu-common.h:
#define QEMU_DPRINTF(cond,pfx,fmt,...) \
do { \
if (cond) {
fprintf(stderr, pfx # ": " fmt, ## __VA_ARGS__); \
} \
while(0)
This file (and other):
#ifndef DEBUG_I82374
#define DEBUG_I82374 0
#endif
#define DPRINTF(fmt, ...) QEMU_DPRINTF(DEBUG_I82374, "I82374", fmt, ##
__VA_ARGS__)
which is just 4 lines per file.
FWIW.
Thanks,
/mjt
- [Qemu-devel] [PATCH 06/14] s390x: Convert conditional compilation of debug printfs to regular ifs, (continued)
- [Qemu-devel] [PATCH 06/14] s390x: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 09/14] tpm: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 07/14] scsi: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 08/14] sd: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 10/14] target-alpha: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 11/14] slirp: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 13/14] target-s390: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 14/14] qemu: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 12/14] target-i386: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs,
Michael Tokarev <=
- Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs, Kevin Wolf, 2014/04/28
- Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs, Michael Tokarev, 2014/04/28
- Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs, Peter Crosthwaite, 2014/04/28
- Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs, Andreas Färber, 2014/04/28