[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/14] net: Convert conditional compilation of d
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 03/14] net: Convert conditional compilation of debug printfs to regular ifs |
Date: |
Mon, 28 Apr 2014 12:10:48 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Apr 28, 2014 at 10:26:04AM +0200, Marc Marí wrote:
> /* Debug EEPRO100 card. */
> #if 0
> -# define DEBUG_EEPRO100
> +#define DEBUG_EEPRO100 1
> #endif
There seem to be a few ways of doing this (commenting out the line,
putting it in #if 0, etc).
Feel free to get rid of #define DEBUG_foo 1 lines completely, leaving
just the #ifndef (I think Kevin suggested this).
Editing the file is bad since it's easy to forget to remove changes when
doing git-commit(1). Debugging should be enabled by recompiling instead
of editing source files:
$ ./configure --extra-cflags=-DDEBUG_FOO=1 && make
But this is just a personal preference, if you want to leave the lines
it's fine.
Stefan
- [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 02/14] i386: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 03/14] net: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- Re: [Qemu-devel] [PATCH 03/14] net: Convert conditional compilation of debug printfs to regular ifs,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 04/14] isa: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 05/14] pci-host: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 06/14] s390x: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 09/14] tpm: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 07/14] scsi: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 08/14] sd: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28
- [Qemu-devel] [PATCH 10/14] target-alpha: Convert conditional compilation of debug printfs to regular ifs, Marc Marí, 2014/04/28