Re: [Qemu-devel] [PATCH 6/7] slirp: Add description of new "dhcpvendopt" suboption to the help and man page

[Eric Blake]

On 04/25/2014 04:11 PM, Fedor Lyakhov wrote:
> Signed-off-by: Fedor Lyakhov <address@hidden>
> ---
>  qemu-options.hx | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)

> +    "         
> [,hostname=host][,dhcpstart=addr][,dns=addr][,dhcpvendopt=optstring]\n"

>  
> address@hidden address@hidden
> +Specify list of vendor-specific DHCP options (option 43) reported by the
> +built-in DHCP server (see RFC2132). The @var{optstring} should be specified 
> in
> +the following form: "tag1:value1;tag2:value2", i.e. each option is separated 
> by
> +';' semicolon (Note: on most terminals it must be escaped '\;'), option tag 
> and

It's not the terminal, but the shell, which requires escaping of ';'.

> +value are separated by ':' colon. Accepted tag values are [1-254]. Single
> +tag-less option "value" is also supported. Zero tag "0:" can be used to
> +'escape' special single options beginning with tag-like value (e.g. single 
> MAC
> +address can be specified as "0:10:FE:20:AB:CD:78").

Rather than inventing YET ANOTHER command line quoting idiom in order to
cram multiple strings into one option, can you instead manage to rework
things so that the user can pass multiple dhcpvendopt= options, one per
string?  That is, dhcpvendopt=tag1:value1\;tag2:value2 is ad-hoc, while
dhcpvendopt=tag1=value1,dhcpvendopt=tag2=value2 could reuse existing
machinery.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature