Re: [Qemu-devel] [RFC PATCH V3 0/7] PSCI v0.2 support for KVM ARM/ARM64

[Pranavkumar Sawargaonkar]

Hi Peter,

On 28 April 2014 22:44, Peter Maydell <address@hidden> wrote:
> On 10 April 2014 12:46, Pranavkumar Sawargaonkar <address@hidden> wrote:
>> Recentely patches have been posted for in-kernel emulation of PSCI v0.2
>> http://www.spinics.net/lists/arm-kernel/msg305467.html
>> This patchset adds the QEMU side changes for providing PSCI v0.2 to VM.
>>
>> ChangeLog:
>>
>> V3:
>>  - Rebase this patchset against v8 patchset for in-kernel PSCI v0.2 emulation
>>    (http://www.spinics.net/lists/kvm-arm/msg08780.html)
>>  - Added common kvm_arm_vcpu_init() function for kvm arm and kvm arm64
>>
>> V2:
>>  - Rebase this patchset against v6 patchset for in-kernel PSCI v0.2 emulation
>>    (http://www.spinics.net/lists/arm-kernel/msg319037.html)
>>  - Handle KVM_EXIT_SYSTEM_EVENT in kvm-all.c:kvm_cpu_exec()
>>  - Drop change in kvm_arm_get_host_cpu_features()
>>  - Improve comments and description of kvm_arch_reset_vcpu() implementation
>>
>> V1:
>>  - Initial RFC patchset
>
> For the record, all the issues I raised in review commentary
> for v2 still apply.
>

I have addressed your comment about kvm_arch_init_vcpu() function
([RFC PATCH V2 4/6] target-arm: Implement kvm_arch_reset_vcpu() for KVM ARM64)
in -
[RFC PATCH V3 6/7] target-arm: Common kvm_arm_vcpu_init() for KVM ARM
and KVM ARM64
[RFC PATCH V3 7/7] target-arm: Implement kvm_arch_reset_vcpu() for KVM ARM64

Regarding comment about migration incompatibility:
([RFC PATCH V2 3/6] target-arm: Enable KVM_ARM_VCPU_PSCI_0_2 feature
when possible)

During v1 patchset of Christoffer mentioned that he will address it
during migration of armv8.
But till that time can we go ahead with current approach, I can put a
comment about this in code ?

> thanks
> -- PMM

Thanks,
Pranav