Re: [Qemu-devel] [PATCH v3 16/16] tcg: Require TCG_TARGET_INSN_UNIT_SIZE

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> Now that all backends do define TCG_TARGET_INSN_UNIT_SIZE,
> remove the fallback definition.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>

> ---
>  tcg/tcg.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tcg/tcg.h b/tcg/tcg.h
> index a3fb88c..4f4b1fa 100644
> --- a/tcg/tcg.h
> +++ b/tcg/tcg.h
> @@ -147,9 +147,8 @@ typedef enum TCGOpcode {
>  #define tcg_regset_not(d, a) (d) = ~(a)
>  
>  #ifndef TCG_TARGET_INSN_UNIT_SIZE
> -#define TCG_TARGET_INSN_UNIT_SIZE 1
> -#endif
> -#if TCG_TARGET_INSN_UNIT_SIZE == 1
> +# error "Missing TCG_TARGET_INSN_UNIT_SIZE"
> +#elif TCG_TARGET_INSN_UNIT_SIZE == 1
>  typedef uint8_t tcg_insn_unit;
>  #elif TCG_TARGET_INSN_UNIT_SIZE == 2
>  typedef uint16_t tcg_insn_unit;

-- 
Alex Bennée