Re: [Qemu-devel] [PATCH 09/16] pci-assign: assignment should fail if we can't read config space

[Eric Blake]

On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> assigned_initfn()
>   get_real_device()
>     read()
> 
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
>  hw/i386/kvm/pci-assign.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <address@hidden>

> 
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index f91d4fb..e89bb6a 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -574,10 +574,11 @@ again:
>      if (r < 0) {
>          if (errno == EINTR || errno == EAGAIN) {
>              goto again;
>          }
>          error_report("%s: read failed, errno = %d", __func__, errno);
> +        return 1;
>      }
>  
>      /* Restore or clear multifunction, this is always controlled by qemu */
>      if (pci_dev->dev.cap_present & QEMU_PCI_CAP_MULTIFUNCTION) {
>          pci_dev->dev.config[PCI_HEADER_TYPE] |= 
> PCI_HEADER_TYPE_MULTI_FUNCTION;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature