[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 14/14] iotests: Omit length/offset test in 04
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 14/14] iotests: Omit length/offset test in 040 and 041 |
Date: |
Tue, 29 Apr 2014 21:14:07 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/29/2014 09:17 AM, Max Reitz wrote:
> As the length of a mirror block job no longer directly depends on the
> size of the block device, drop those checks from this test. Instead,
> just check whether the final offset equals the block job length.
>
> As 041 uses the wait_until_completed function from iotests.py, the same
> applies there as well which in turn affects tests 030, 055 and 056. On
> the other hand, a block job's length does not have to be related to the
> length of the image file in the first place, so that check was
> questionable anyway.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/040 | 4 +---
> tests/qemu-iotests/041 | 3 +--
> tests/qemu-iotests/iotests.py | 3 +--
> 3 files changed, 3 insertions(+), 7 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v6 07/14] qemu-img: Implement commit like QMP, (continued)
- [Qemu-devel] [PATCH v6 08/14] qemu-img: Empty image after commit, Max Reitz, 2014/04/29
- [Qemu-devel] [PATCH v6 09/14] qemu-img: Enable progress output for commit, Max Reitz, 2014/04/29
- [Qemu-devel] [PATCH v6 10/14] qemu-img: Specify backing file for commit, Max Reitz, 2014/04/29
- [Qemu-devel] [PATCH v6 11/14] iotests: Add _filter_qemu_img_map, Max Reitz, 2014/04/29
- [Qemu-devel] [PATCH v6 12/14] iotests: Add test for backing-chain commits, Max Reitz, 2014/04/29