Re: [Qemu-devel] [Qemu-trivial] [PATCH V5 1/1] qmp: add pmemload command

[Baojun Wang]

Sorry for reply late Michael (my gmail priority inbox didn't sort this email into my inbox), I thought the change is trivial compare to the huge patch set in the mailing list :)

I'm OK with the change not one in the -trivial tree.

Best Regards
Baojun

On Sun, Apr 27, 2014 at 2:18 AM, Michael Tokarev <address@hidden> wrote:

09.04.2014 21:49, Baojun Wang wrote:
> I found this could be useful to have qemu-softmmu as a cross debugger (launch
> with -s -S command line option), then if we can have a command to load guest
> physical memory, we can use cross gdb to do some target debug which gdb cannot
> do directly.
>
> Many thanks to Eric Blake for review the patch and suggestions.

Okay, that looks sane, but can you explain please, why did you address
address@hidden  The change definitely is not "trivial", as it introduces
a new qmp command which becomes a part of public interface.  Even if
the implementation may look trivial, the interface change should not be
done using -trivial tree.

Thanks,

/mjt