[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/22] vmdk: implement .bdrv_detach/attach_aio_c
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 18/22] vmdk: implement .bdrv_detach/attach_aio_context() |
Date: |
Sun, 4 May 2014 17:50:44 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 05/01 16:54, Stefan Hajnoczi wrote:
> Implement .bdrv_detach/attach_aio_context() interfaces to propagate
> detach/attach to BDRVVmdkState->extents[].file. The block layer takes
> care of ->file and ->backing_hd but doesn't know about our extents
> BlockDriverStates, which is also part of the graph.
>
> Cc: Fam Zheng <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block/vmdk.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 06a1f9f..1ca944a 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -2063,6 +2063,27 @@ static ImageInfoSpecific
> *vmdk_get_specific_info(BlockDriverState *bs)
> return spec_info;
> }
>
> +static void vmdk_detach_aio_context(BlockDriverState *bs)
> +{
> + BDRVVmdkState *s = bs->opaque;
> + int i;
> +
> + for (i = 0; i < s->num_extents; i++) {
> + bdrv_detach_aio_context(s->extents[i].file);
> + }
> +}
> +
> +static void vmdk_attach_aio_context(BlockDriverState *bs,
> + AioContext *new_context)
> +{
> + BDRVVmdkState *s = bs->opaque;
> + int i;
> +
> + for (i = 0; i < s->num_extents; i++) {
> + bdrv_attach_aio_context(s->extents[i].file, new_context);
> + }
> +}
> +
> static QEMUOptionParameter vmdk_create_options[] = {
> {
> .name = BLOCK_OPT_SIZE,
> @@ -2118,6 +2139,8 @@ static BlockDriver bdrv_vmdk = {
> .bdrv_has_zero_init = vmdk_has_zero_init,
> .bdrv_get_specific_info = vmdk_get_specific_info,
> .bdrv_refresh_limits = vmdk_refresh_limits,
> + .bdrv_detach_aio_context = vmdk_detach_aio_context,
> + .bdrv_attach_aio_context = vmdk_attach_aio_context,
>
> .create_options = vmdk_create_options,
> };
Looks good to me,
Reviewed-by: Fam Zheng <address@hidden>
- [Qemu-devel] [PATCH 13/22] block/raw-posix: implement .bdrv_detach/attach_aio_context(), (continued)
- [Qemu-devel] [PATCH 13/22] block/raw-posix: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/01
- [Qemu-devel] [PATCH 17/22] ssh: use BlockDriverState's AioContext, Stefan Hajnoczi, 2014/05/01
- [Qemu-devel] [PATCH 19/22] dataplane: use the QEMU block layer for I/O, Stefan Hajnoczi, 2014/05/01
- [Qemu-devel] [PATCH 18/22] vmdk: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/01
- [Qemu-devel] [PATCH 21/22] dataplane: implement async flush, Stefan Hajnoczi, 2014/05/01
- [Qemu-devel] [PATCH 16/22] sheepdog: implement .bdrv_detach/attach_aio_context(), Stefan Hajnoczi, 2014/05/01
- [Qemu-devel] [PATCH 20/22] dataplane: delete IOQueue since it is no longer used, Stefan Hajnoczi, 2014/05/01
- [Qemu-devel] [PATCH 22/22] raw-posix: drop raw_get_aio_fd() since it is no longer used, Stefan Hajnoczi, 2014/05/01
- Re: [Qemu-devel] [PATCH 00/22] dataplane: use QEMU block layer, Paolo Bonzini, 2014/05/02
- Re: [Qemu-devel] [PATCH 00/22] dataplane: use QEMU block layer, Christian Borntraeger, 2014/05/05