[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] iotests: Use configured python
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] iotests: Use configured python |
|
Date: |
Mon, 05 May 2014 08:02:05 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/05/2014 06:26 AM, Stefan Hajnoczi wrote:
>> - [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>> +
>> + if [ "$(head -n 1 $seq)" == "#!/usr/bin/env python" ]; then
>> + run_command="$PYTHON $seq"
>
> The code generally uses the older `` notation instead of $(). Please
> use ``.
I'd rather scrub the sources to get rid of all `` and use $() instead.
`` is obsolete. Sounds like a good beginner's project, if someone wants
a summer of code warmup...
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature