Re: [Qemu-devel] [PATCH 0/5] glib thread interface and libcacard cleanups

[Michael Tokarev]

05.05.2014 18:49, Alon Levy wrote:
> On 04/29/2014 09:02 AM, Michael Tokarev wrote:
>> Basically libgthread has been rewritten in glib version 2.31, and old ways
>> to use thread primitives stopped working while new ways appeared.  The two
>> interfaces were sufficiently different to warrant large ifdeffery across all
>> code using it.
[...]
[]
> Reviewed-by: Alon Levy <address@hidden>
> Tested-by: Alon Levy <address@hidden>

Hmm.  Now I'm a bit confused.  Which version did you test? :)

I posted a v2 patch which splits one of the changes into two
(pstrcpy to memcpy conversion in libcacard), added some more
(minor) changes (which should not affect libcacard code in
any way), and adjusted commit messages.

The main code is not affected (or should not be), so Tested-by
probably may stay, except of the pstrcpy to memcpy patch
(http://patchwork.ozlabs.org/patch/345002/) which may affect
libcacard.

Here's the v2: 
http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00286.html

If you tested the git branch which I referred to, that's the
v2, not original submission which you're replying to.

> This would be nice to have too (it has nothing to do with your patchset,
> but it would save me a pull request):
> 
> commit 2fc95f8bc1912e2de243389d9d102a5a28267f31
> Author: Alon Levy <address@hidden>
> Date:   Mon May 5 17:41:32 2014 +0300
> 
>     libcacard: remove unnecessary EOL from debug prints

Well, this can easily go to -trivial, as I'm planning to send a pull
request for it soon anyway.

Thank you!

/mjt