qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/13] tests: Don't call visit_end_struct() afte


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 11/13] tests: Don't call visit_end_struct() after visit_start_struct() fails
Date: Mon, 05 May 2014 15:12:41 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/02/2014 06:44 AM, Markus Armbruster wrote:
> When visit_start_struct() succeeds, visit_end_struct() must not be

As in 10/13, s/succeeds/fails/

> called.  Three out of four visit_type_TestStruct() call it anyway.  As
> far as I can tell, visit_start_struct() doesn't actually fail there.
> Fix them anyway.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  tests/test-qmp-input-strict.c      | 18 +++++++++++++-----
>  tests/test-qmp-output-visitor.c    | 18 +++++++++++++-----
>  tests/test-visitor-serialization.c | 18 +++++++++++++-----
>  3 files changed, 39 insertions(+), 15 deletions(-)
> 

With commit message fixed,

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]