[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] block: Allow JSON filenames
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/4] block: Allow JSON filenames |
|
Date: |
Tue, 06 May 2014 14:28:54 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/06/2014 02:00 PM, Max Reitz wrote:
>>
>> -drive
>> file='json:{"driver":"qcow2","file.filename":"foo","backing.file.driver":"raw"}',backing.file.driver=qcow2
>>
>>
>> looks like it specifies conflicting backing.file.driver options.
>> Passing true means that qdict_join silently overwrites the value in
>> options to instead be the value in the json string; passing false means
>> you could flag the user error.
>
> Yes, you're right; I'll change it.
And of course, bonus points if you enhance the testsuite to provoke the
error and prove we detect it :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 2/4] check-qdict: Add test for qdict_join(), Max Reitz, 2014/05/06
[Qemu-devel] [PATCH 4/4] iotests: Add test for the JSON protocol, Max Reitz, 2014/05/06