[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/38] QMP queue
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PULL 00/38] QMP queue |
Date: |
Fri, 9 May 2014 08:58:30 -0400 |
On Fri, 09 May 2014 14:54:45 +0200
Markus Armbruster <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
>
> > On 8 May 2014 19:52, Luiz Capitulino <address@hidden> wrote:
> >> The following changes since commit
> >> 6b342cc9c872e82620fdd32730cd92affa8a19b3:
> >>
> >> Merge remote-tracking branch 'remotes/spice/tags/pull-spice-7'
> >> into staging (2014-05-08 10:57:25 +0100)
> >>
> >> are available in the git repository at:
> >>
> >>
> >> git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
> >>
> >> for you to fetch changes up to 4c56cbae6908cc597842e86e523886bb8ea8cfb8:
> >>
> >> Revert "qapi: Clean up superfluous null check in
> >> qapi_dealloc_type_str()" (2014-05-08 14:20:26 -0400)
> >
> > Hi; this doesn't build for w32, I'm afraid:
> >
> > /home/petmay01/linaro/qemu-for-merges/qga/vss-win32.c: In function
> > ‘qga_vss_fsfreeze’:
> > /home/petmay01/linaro/qemu-for-merges/qga/vss-win32.c:160: error:
> > ‘err’ undeclared (first use in this function)
> > /home/petmay01/linaro/qemu-for-merges/qga/vss-win32.c:160: error:
> > (Each undeclared identifier is reported only once
> > /home/petmay01/linaro/qemu-for-merges/qga/vss-win32.c:160: error: for
> > each function it appears in.)
>
> My fault! Apologies...
>
> The obvious fix needs to be squashed into "qga: Consistently name Error
> ** objects errp, and not err":
Yep. I'm testing this right now. A clear indication that neither you or
me are testing builds on w32/64.
We need a buildbot badly.
- [Qemu-devel] [PULL 31/38] qga: Clean up fragile use of error_is_set(), (continued)
- [Qemu-devel] [PULL 31/38] qga: Clean up fragile use of error_is_set(), Luiz Capitulino, 2014/05/08
- [Qemu-devel] [PULL 34/38] dump: Drop pointless error_is_set(), DumpState member errp, Luiz Capitulino, 2014/05/08
- [Qemu-devel] [PULL 38/38] Revert "qapi: Clean up superfluous null check in qapi_dealloc_type_str()", Luiz Capitulino, 2014/05/08
- [Qemu-devel] [PULL 35/38] qmp: Don't use error_is_set() to suppress additional errors, Luiz Capitulino, 2014/05/08
- [Qemu-devel] [PULL 33/38] qemu-option: Clean up fragile use of error_is_set(), Luiz Capitulino, 2014/05/08
- [Qemu-devel] [PULL 36/38] qmp: use valid JSON in transaction example, Luiz Capitulino, 2014/05/08
- [Qemu-devel] [PULL 32/38] qga: Drop superfluous error_is_set(), Luiz Capitulino, 2014/05/08
- [Qemu-devel] [PULL 37/38] qapi: Document optional arguments' backwards compatibility, Luiz Capitulino, 2014/05/08
- Re: [Qemu-devel] [PULL 00/38] QMP queue, Peter Maydell, 2014/05/09