|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [RFC PATCH 01/11] hw: use ld_p/st_p instead of ld_raw/st_raw |
| Date: | Fri, 09 May 2014 21:03:03 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Il 09/05/2014 20:18, Peter Maydell ha scritto:
The virtio parts of this look dubious. What actual endianness does the virtio spec say that things like the block device geometry should have in memory? I suspect we should be using the use-the-virtio-endianness accessors Greg's on-list patches implement, which renders the raw-vs-p question moot. In any case you'll probably have patch conflicts there.
It's "target" endianness. Yes, there would be conflicts.
For nseries.c I think I'd prefer we do the checkpatch fixups. There's no reason we can't do this now (ie we don't wait on the fixes which make the rest of this series an RFC),
Ok. Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |