[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v19 08/16] block: Parse "backing" option to referenc
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v19 08/16] block: Parse "backing" option to reference existing BDS |
Date: |
Mon, 12 May 2014 09:35:47 +0800 |
Now it's safe to allow reference for backing_hd in the interface.
Signed-off-by: Fam Zheng <address@hidden>
---
block.c | 27 +++++++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 8155e68..bb7031f 100644
--- a/block.c
+++ b/block.c
@@ -1443,12 +1443,35 @@ int bdrv_open(BlockDriverState **pbs, const char
*filename,
/* If there is a backing file, use it */
if ((flags & BDRV_O_NO_BACKING) == 0) {
QDict *backing_options;
+ const char *backing_name;
+ BlockDriverState *backing_hd;
+ backing_name = qdict_get_try_str(options, "backing");
qdict_extract_subqdict(options, &backing_options, "backing.");
- ret = bdrv_open_backing_file(bs, backing_options, &local_err);
- if (ret < 0) {
+
+ if (backing_name && qdict_size(backing_options)) {
+ error_setg(&local_err,
+ "Option \"backing\" and \"backing.*\" cannot be "
+ "used together");
+ ret = -EINVAL;
goto close_and_fail;
}
+ if (backing_name) {
+ backing_hd = bdrv_find(backing_name);
+ if (!backing_hd) {
+ error_set(&local_err, QERR_DEVICE_NOT_FOUND, backing_name);
+ ret = -ENOENT;
+ goto close_and_fail;
+ }
+ qdict_del(options, "backing");
+ bdrv_set_backing_hd(bs, backing_hd);
+ bdrv_ref(backing_hd);
+ } else {
+ ret = bdrv_open_backing_file(bs, backing_options, &local_err);
+ if (ret < 0) {
+ goto close_and_fail;
+ }
+ }
}
/* For snapshot=on, create a temporary qcow2 overlay. bs points to the
--
1.9.2
- Re: [Qemu-devel] [PATCH v19 03/16] block: Introduce op_blockers to BlockDriverState, (continued)
- [Qemu-devel] [PATCH v19 08/16] block: Parse "backing" option to reference existing BDS,
Fam Zheng <=
- [Qemu-devel] [PATCH v19 09/16] block: Support dropping active in bdrv_drop_intermediate, Fam Zheng, 2014/05/11
- [Qemu-devel] [PATCH v19 10/16] stream: Use bdrv_drop_intermediate and drop close_unused_images, Fam Zheng, 2014/05/11
- [Qemu-devel] [PATCH v19 11/16] commit: Use bdrv_drop_intermediate, Fam Zheng, 2014/05/11
- [Qemu-devel] [PATCH v19 12/16] qmp: Add command 'blockdev-backup', Fam Zheng, 2014/05/11
- [Qemu-devel] [PATCH v19 13/16] block: Allow backup on referenced named BlockDriverState, Fam Zheng, 2014/05/11
- [Qemu-devel] [PATCH v19 14/16] block: Add blockdev-backup to transaction, Fam Zheng, 2014/05/11
- [Qemu-devel] [PATCH v19 15/16] qemu-iotests: Test blockdev-backup in 055, Fam Zheng, 2014/05/11