|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 03/10] tcg: Push tcg-runtime routines into exec/helper-* |
Date: | Tue, 13 May 2014 06:39:02 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/13/2014 02:20 AM, Alex Bennée wrote: >> +#ifdef TARGET_LONG_BITS >> > +# if TARGET_LONG_BITS == 32 >> > +# define dh_alias_tl i32 >> > +# else >> > +# define dh_alias_tl i64 >> > +# endif > This bit seems unrelated to the rest of the patch. In fact I can't see > any uses of the dh_alias_* in the code base although there is some > dh_alias() glue magic that could be throwing me off. > It's the fact that the file gets used in tcg-runtime.c, a generic file compiled once that does not have TARGET_LONG_BITS defined at all. I take care to leave "tl" undefined as an alias so that we'd get a compile-time error if it were used. r~
[Prev in Thread] | Current Thread | [Next in Thread] |