Re: [Qemu-devel] OS X compile fix

[Andreas Färber]

Hi,

Am 18.05.2014 01:14, schrieb Peter Bartoli:
> 
> At the recommendation of Mark Cave-Ayland, I'm sending this patch in to
> remedy a long-time Mac OS X compile issue.

Define "long-time"? 2.0 compiled just fine for me on v10.5.8 with
gcc-4.2. I see a number of deprecation and possibly-used-uninitialized
warnings but no breakage. What OSX version and what compiler are you
using, and what error or warning are you seeing without your patch?

Right now on qemu.git I have a different build issue: In scripts/qapi.py
"except IOError as e" needs to be "except IOError, e". But
block/raw-posix.c still builds fine here.

>  The offsets are a way off in
> this diff, but it still works.

Offsets are not the only issue with this "patch", see
http://wiki.qemu-project.org/Contribute/SubmitAPatch

* HTML format
* No Signed-off-by
* No [PATCH]
* Block maintainers not CC'ed (not so important here)
* Insufficient description of what is being fixed

Regards,
Andreas

> --- block/raw-posix.c.orig      2012-12-03 11:37:05.000000000 -0800
> +++ block/raw-posix.c   2012-12-03 18:24:47.000000000 -0800
> @@ -914,11 +914,11 @@
>                          size = 0;
>          }
>          if (size == 0)
>  #endif
>  #if defined(__APPLE__) && defined(__MACH__)
> -        size = LONG_LONG_MAX;
> +        size = LLONG_MAX;
>  #else
>          size = lseek(fd, 0LL, SEEK_END);
>  #endif
>  #if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
>          switch(s->type) {