qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties


From: Greg Kurz
Subject: Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties
Date: Mon, 19 May 2014 14:45:38 +0200

On Mon, 19 May 2014 14:02:39 +0200
Alexander Graf <address@hidden> wrote:

> 
> On 19.05.14 10:38, Greg Kurz wrote:
> > Hi,
> >
> > This patch set tries to address comments from the initial
> > review. For this round, I have focused on two changes:
> > - as suggested by Andreas, we now call the device specific
> >    code from the generic code to ease the implementation of
> >    future devices. This is achieved with the addition of
> >    load/save methods to VirtioDeviceClass.
> > - virtio subsections now implement a "needed" concept with
> >    the same semantics as in the VMState code.
> >
> > I haven't looked at compat mode issues yet, but it is
> > on my TODO list.
> 
> If you fix up the comments to be either
> 
>    /*
>     * foo
>     */
> 
> or
> 
>    /* foo */
> 
> style, not
> 
>    /* foo
>     */
> 
> then you get my
> 
> 
> Acked-by: Alexander Graf <address@hidden>
> 
> 
> Alex
> 

I'll certainly do that then ! :)

BTW, the faulty comments are in patch 8/8 that I was
sending for informational purpose only as it is part
of the bi-endian virtio serie. Should I merge the
two patch sets at some point ?

-- 
Gregory Kurz                                     address@hidden
                                                 address@hidden
Software Engineer @ IBM/Meiosys                  http://www.ibm.com
Tel +33 (0)562 165 496

"Anarchy is about taking complete responsibility for yourself."
        Alan Moore.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]