Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

[Gabriel L. Somlo]

On Mon, May 19, 2014 at 10:44:48PM +0300, Michael S. Tsirkin wrote:
> Thanks!
> One question: we don't seem to have unit-test for this
> interface in qemu, do we?
> I would like to see at least a basic test along the lines of
> tests/acpi-test.c: run bios to load tables from QEMU,
> then do some basic checks on the tables that bios loaded.

Heh, this is starting to feel a bit like "work" ;)

So, to be a good citizen, I took a look at acpi-test.c,
and it feels like if I just attempted to "cargo-cult" it,
creating a working unit test for the new smbios interface
is going to take me a while...

Is there anything I can RTFM that I could use to (more or
less gently) teach myself how to write a sane QEMU unit test?

Thanks much,
--Gabriel

> 
> > Gabriel L. Somlo (3):
> >   SMBIOS: Fix endian-ness when populating multi-byte fields
> >   SMBIOS: Update Type 0 struct generator for machines >= 2.1
> >   SMBIOS: Fix type 17 field sizes
> > 
> >  hw/i386/smbios.c         | 110 
> > +++++++++++++++++++++++++----------------------
> >  include/hw/i386/smbios.h |  10 ++---
> >  qemu-options.hx          |   4 +-
> >  3 files changed, 65 insertions(+), 59 deletions(-)
> > 
> > -- 
> > 1.9.0