[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] set the frequency of the dump bitmap proces
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] set the frequency of the dump bitmap process |
Date: |
Tue, 20 May 2014 13:36:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote:
> This patch introduces both qmp and hmp (log-dirty-bitmap-set-frequency)
> interface to update the value of the frequency.
>
> Signed-off-by: Sanidhya Kashyap <address@hidden>
> ---
> +++ b/qapi-schema.json
> @@ -4715,3 +4715,11 @@
> # cancel the dirty bitmap logging process
> ##
> { 'command': 'log-dirty-bitmap-cancel' }
> +
> +## @log-dirty-bitmap-set-frequency
> +#
> +# sets the frequency of the dirty bitmap logging process
> +##
Same comments as in other patches about missing documentation.
> +{ 'command': 'log-dirty-bitmap-set-frequency',
> + 'data': {'frequency': 'int' } }
> +
> diff --git a/qmp-commands.hx b/qmp-commands.hx
Please don't end files with an extra blank line.
> +Arguments:
> +
> +- "frequency": the updated frequency (json-int)
In what unit? I'm assuming milliseconds based on the rest of the series,
but spelling it out will help readers.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/6] bitmap dump code via QAPI framework, (continued)
- [Qemu-devel] [PATCH 3/6] hmp interface for dirty bitmap dump, Sanidhya Kashyap, 2014/05/20
- [Qemu-devel] [PATCH 4/6] cancel mechanism for an already running dump bitmap process, Sanidhya Kashyap, 2014/05/20
- [Qemu-devel] [PATCH 5/6] set the frequency of the dump bitmap process, Sanidhya Kashyap, 2014/05/20
- Re: [Qemu-devel] [PATCH 5/6] set the frequency of the dump bitmap process,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging, ChenLiang, 2014/05/21
- Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging, Sanidhya Kashyap, 2014/05/21
- Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging, ChenLiang, 2014/05/21
- Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging, Sanidhya Kashyap, 2014/05/21
- Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging, Sanidhya Kashyap, 2014/05/22
- Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging, ChenLiang, 2014/05/22
- Re: [Qemu-devel] [PATCH 0/6] Obtain dirty bitmap via VM logging, Sanidhya Kashyap, 2014/05/22