[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] virtio-balloon: return empty data when no st
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] virtio-balloon: return empty data when no stats are available |
Date: |
Wed, 21 May 2014 05:23:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/21/2014 03:03 AM, Ján Tomko wrote:
> If the guest hasn't updated the stats yet, instead of returning
> an error, return '-1' for the stats and '0' as 'last-update'.
>
> This lets applications ignore this without parsing the error message.
>
> Related libvirt patch and discussion:
> https://www.redhat.com/archives/libvir-list/2014-May/msg00460.html
>
> Tested against current upstream libvirt - stat reporting works and
> it no longer logs errors when the stats are queried on domain startup.
> (Note: libvirt doesn't use the last-update field for anything yet)
>
> Signed-off-by: Ján Tomko <address@hidden>
> ---
> v1: https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03643.html
> Reviewed-by: Eric Blake <address@hidden>
> v2:
> rebased
> added documentation changes
> mentioned testing in the commit message
Additional commit message and doc changes are good.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature