[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDr
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState |
Date: |
Wed, 21 May 2014 16:49:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes:
> On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote:
>> This makes use of op_blocker and blocks all the operations except for
>> commit target, on each BlockDriverState->backing_hd.
>>
>> The asserts for op_blocker in bdrv_swap are removed because with this
>> change, the target of block commit has at least the backing blocker of
>> its child, so the assertion is not true. Callers should do their check.
>>
>> Signed-off-by: Fam Zheng <address@hidden>
>> ---
>> block.c | 22 ++++++++++++++++++----
>> block/mirror.c | 1 +
>> include/block/block_int.h | 3 +++
>> 3 files changed, 22 insertions(+), 4 deletions(-)
>
> IMO it would be nice to split the series after this patch.
>
> The op_blocker stuff looks solid and the series is at v20. Let's handle
> the rest of the changes in separate, smaller series that can be easily
> digested.
Yes, please!
[Qemu-devel] [PATCH v20 08/15] block: Support dropping active in bdrv_drop_intermediate, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 09/15] stream: Use bdrv_drop_intermediate and drop close_unused_images, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 10/15] commit: Use bdrv_drop_intermediate, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 11/15] qmp: Add command 'blockdev-backup', Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 12/15] block: Allow backup on referenced named BlockDriverState, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 13/15] block: Add blockdev-backup to transaction, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 14/15] qemu-iotests: Test blockdev-backup in 055, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 15/15] qemu-iotests: Image fleecing test case 089, Fam Zheng, 2014/05/20