[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/7] block: Use bdrv_set_backing_hd everywhere
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 6/7] block: Use bdrv_set_backing_hd everywhere |
Date: |
Fri, 23 May 2014 14:48:43 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, May 23, 2014 at 11:23:22AM +0800, Fam Zheng wrote:
> We need to handle the coming backing_blocker properly, so don't open
> code the assignment, instead, call bdrv_set_backing_hd to change
> backing_hd.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block.c | 4 ++--
> block/stream.c | 4 ++--
> block/vvfat.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/block.c b/block.c
> index 911ba68..91c866c 100644
> --- a/block.c
> +++ b/block.c
> @@ -2652,13 +2652,13 @@ int bdrv_drop_intermediate(BlockDriverState *active,
> BlockDriverState *top,
> if (ret) {
> goto exit;
> }
> - new_top_bs->backing_hd = base_bs;
> + bdrv_set_backing_hd(new_top_bs, base_bs);
>
> bdrv_refresh_limits(new_top_bs);
Please ignore what I said about backing_hd and base_bs being non-NULL,
it doesn't matter. bdrv_set_backing_hd() always calls
bdrv_refresh_limits() so we definitely don't need to call it again here.
- [Qemu-devel] [PATCH 0/7] block: Drop in_use with op blocker, Fam Zheng, 2014/05/22
- [Qemu-devel] [PATCH 1/7] block: Add BlockOpType enum, Fam Zheng, 2014/05/22
- [Qemu-devel] [PATCH 2/7] block: Introduce op_blockers to BlockDriverState, Fam Zheng, 2014/05/22
- [Qemu-devel] [PATCH 3/7] block: Replace in_use with operation blocker, Fam Zheng, 2014/05/22
- [Qemu-devel] [PATCH 4/7] block: Move op_blocker check from block_job_create to its caller, Fam Zheng, 2014/05/22
- [Qemu-devel] [PATCH 5/7] block: Add bdrv_set_backing_hd(), Fam Zheng, 2014/05/22
- [Qemu-devel] [PATCH 6/7] block: Use bdrv_set_backing_hd everywhere, Fam Zheng, 2014/05/22
- [Qemu-devel] [PATCH 7/7] block: Add backing_blocker in BlockDriverState, Fam Zheng, 2014/05/22