[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] block: replace fprintf(stderr, ...) with err
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] block: replace fprintf(stderr, ...) with error_report() |
|
Date: |
Sun, 25 May 2014 22:29:11 +0800 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2014-05-25 10:44, Le Tan wrote:
> Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
> block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument
> have been removed because @fmt of error_report() should not contain newline.
> Also fix some coding style issues.
Let's do the "also" part in a separate patch. It's more than one or two
trivial pass-by style fixes, and some people may like the fprintf
conversion while having different views on the other changes.
Jan
signature.asc
Description: OpenPGP digital signature