[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts |
Date: |
Tue, 27 May 2014 21:48:57 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/07/2014 03:58 AM, Chunyan Liu wrote:
> vvfat shares create options of qcow driver. To avoid vvfat breaking when
> qcow driver changes from QEMUOptionParameter to QemuOpts, let it able
> to handle both cases.
>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
> Change:
> * Fix memory free:
> - qemu_opts_free(create_opts);
> + if (bdrv_qcow->create_options) {
> + qemu_opts_free(create_opts);
> + }
>
> block/vvfat.c | 23 +++++++++++++++++------
> 1 file changed, 17 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v27 08/33] QemuOpts: add qemu_opts_print_help to replace print_option_help, (continued)
- [Qemu-devel] [PATCH v27 08/33] QemuOpts: add qemu_opts_print_help to replace print_option_help, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 09/33] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 03/33] QemuOpts: add def_value_str to QemuOptDesc, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 04/33] qapi: output def_value_str when query command line options, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 07/33] QemuOpts: add qemu_opt_get_*_del functions for replace work, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 02/33] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 11/33] QemuOpts: check NULL input for qemu_opts_del, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts, Chunyan Liu, 2014/05/07
- Re: [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts,
Eric Blake <=
- [Qemu-devel] [PATCH v27 10/33] QemuOpts: add qemu_opts_append to replace append_option_parameters, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 16/33] iscsi.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 14/33] cow.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 15/33] gluster.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 17/33] nfs.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 12/33] change block layer to support both QemuOpts and QEMUOptionParamter, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 18/33] qcow.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 21/33] qed.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/05/07