[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/10] block: Avoid bdrv_get_geometry() where
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 10/10] block: Avoid bdrv_get_geometry() where errors should be detected |
|
Date: |
Wed, 28 May 2014 15:25:42 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/28/2014 08:25 AM, Markus Armbruster wrote:
> bdrv_get_geometry() hides errors. Use bdrv_nb_sectors() or
> bdrv_getlength() instead where that's obviously inappropriate.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block.c | 11 ++++++++---
> block/qapi.c | 14 ++++++++++----
> qemu-img.c | 59 +++++++++++++++++++++++++++++++++++++++++++++--------------
> 3 files changed, 63 insertions(+), 21 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 09/10] qemu-img: Make img_convert() get image size just once per image, (continued)