qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 05/10] trace: [tcg] Declare TCG tracing helpe


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v4 05/10] trace: [tcg] Declare TCG tracing helper routines
Date: Thu, 29 May 2014 09:10:58 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/29/2014 05:23 AM, Lluís Vilanova wrote:
> +            '#ifdef HELPER_GEN_TRACE_PROXY',
> +            'static inline void %(name)s(%(args)s)',
> +            '{',
> +            '    %(code_new)s',
> +            '    %(proxy_name)s(%(tmp_names)s);',
> +            '    %(code_free)s',
> +            '}',
> +            '#endif',

Why are you mixing code with DEF_HELPER declarations?
Surely putting this in a different file would be better.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]