[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 05/10] trace: [tcg] Declare TCG tracing helpe
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v4 05/10] trace: [tcg] Declare TCG tracing helper routines |
Date: |
Thu, 29 May 2014 09:10:58 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/29/2014 05:23 AM, Lluís Vilanova wrote:
> + '#ifdef HELPER_GEN_TRACE_PROXY',
> + 'static inline void %(name)s(%(args)s)',
> + '{',
> + ' %(code_new)s',
> + ' %(proxy_name)s(%(tmp_names)s);',
> + ' %(code_free)s',
> + '}',
> + '#endif',
Why are you mixing code with DEF_HELPER declarations?
Surely putting this in a different file would be better.
r~
- [Qemu-devel] [PATCH v4 00/10] trace: [tcg] Allow tracing guest events in TCG-generated code, Lluís Vilanova, 2014/05/29
- [Qemu-devel] [PATCH v4 02/10] trace: [tcg] Argument type transformation rules, Lluís Vilanova, 2014/05/29
- [Qemu-devel] [PATCH v4 04/10] trace: [tcg] Add 'tcg' event property, Lluís Vilanova, 2014/05/29
- [Qemu-devel] [PATCH v4 01/10] trace: [tcg] Add documentation, Lluís Vilanova, 2014/05/29
- [Qemu-devel] [PATCH v4 05/10] trace: [tcg] Declare TCG tracing helper routines, Lluís Vilanova, 2014/05/29
- Re: [Qemu-devel] [PATCH v4 05/10] trace: [tcg] Declare TCG tracing helper routines,
Richard Henderson <=
- [Qemu-devel] [PATCH v4 03/10] trace: [tcg] Argument type transformation machinery, Lluís Vilanova, 2014/05/29
- [Qemu-devel] [PATCH v4 06/10] trace: [tcg] Define TCG tracing helper routines, Lluís Vilanova, 2014/05/29
- [Qemu-devel] [PATCH v4 07/10] trace: [tcg] Include TCG-tracing helpers, Lluís Vilanova, 2014/05/29
- [Qemu-devel] [PATCH v4 08/10] trace: [tcg] Generate TCG tracing routines, Lluís Vilanova, 2014/05/29
- [Qemu-devel] [PATCH v4 09/10] trace: [tcg] Include event definitions in "trace.h", Lluís Vilanova, 2014/05/29
- [Qemu-devel] [PATCH v4 10/10] trace: [tcg] Include TCG-tracing header on all targets, Lluís Vilanova, 2014/05/29