Re: [Qemu-devel] [PATCH v3 3/9] spapr_pci: Introduce a finish_realize() callback

[Alexander Graf]

On 29.05.14 03:53, Alexey Kardashevskiy wrote:
> On 05/29/2014 01:11 AM, Alexander Graf wrote:
> > On 27.05.14 07:36, Alexey Kardashevskiy wrote:
> > > The spapr-pci PHB initializes IOMMU for emulated devices only.
> > > The upcoming VFIO support will do it different. However both emulated
> > > and VFIO PHB types share most of the initialization code.
> > > For the type specific things a new finish_realize() callback is
> > > introduced.
> > >
> > > This introduces sPAPRPHBClass derived from PCIHostBridgeClass and
> > > adds the callback pointer.
> > >
> > > This implements finish_realize() for emulated devices.
> > >
> > > Signed-off-by: Alexey Kardashevskiy <address@hidden>
> > This patch breaks compilation on some of my test hosts:
> Rats... Sorry about that. What is that host? I need to setup one for
> myself. I test my stuff to compile on x86_64 (for TCG-ppc, TCG-ppc64 and
> cross for ppc64) and do not hit this.

The hosts that spotted this build breakage in particular were

  1) a ppc64 installation of SLES11 SP3
  2) a ppc64 installation of SLES11 SP1
  3) a ppc32 installation of openSUSE 11.1

which at the end of the day are all using the same ancient 4.3 compiler.


Alex