Re: [Qemu-devel] [RFC 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface

[Eric Blake]

On 05/30/2014 09:39 AM, Igor Mammedov wrote:

>>> +# @source_event: Arg0 - An Integer containing the source event
>>> +#
>>> +# @status_code: Arg1 – An Integer containing the status code
>>

>>> +{ 'type': 'ACPIOSTInfo',
>>> +  'data'  : { 'device': 'str',
>>> +              'source': 'int',
>>> +              'status': 'int',
>>> +              'slot': 'int' } }
>>
>> ...this type declaration.  I have no idea which one of the two is wrong.
> What do you mean under wrong?

Sorry for not being clear enough.  I'm not sure whether you meant to
document four fields (device, source, status, and slot) or whether the
command should have been just two fields ( 'data': { 'source_event':
'int', 'status_code': 'int' } ).

Although re-reading what I just wrote, it appears your 'source' field
matches the 'source_event' documentation, the 'status' field matches the
'status_code' documentation, and you omitted the 'device' and 'slot'
documentation.

And my question in 4/5 remains - should 'source' and/or 'status' be
defined as an enum rather than an open-coded int?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature