qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 5/5] qapi: Set QAPI descriptions files under


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 5/5] qapi: Set QAPI descriptions files under the GPL V2 license
Date: Thu, 05 Jun 2014 10:52:46 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 06/05/2014 05:45 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  qapi-schema.json     | 4 ++++
>  qapi/block-core.json | 4 ++++
>  qapi/block.json      | 4 ++++
>  qapi/common.json     | 4 ++++
>  4 files changed, 16 insertions(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 14b498b..870d3f6 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1,5 +1,9 @@
>  # -*- Mode: Python -*-
>  #
> +# This file is part of the QEMU project.
> +#
> +# This file is licensed under the GPL V2.

Needs a v3.  LICENSE states that all files that have no explicit license
are GPLv2+; adding this explicit license of GPLv2-only makes these files
less free than before.  Also, it is generally required to have a
Copyright line also in the file, before a declaration of GPL licensing
makes sense.

See scripts/qmp/qmp for something that might serve as a better example
of a minimal header boilerplate; although I'm not quite sure who the
best entity is to list for Copyright (Anthony created the file mostly as
a placeholder in commit e3193601 while at IBM; then Luiz did the biggest
chunk of the initial work in getting the file going).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]