Re: [Qemu-devel] [PATCH v3.2 11/31] numa: introduce memory_region_allocate_system_memory

[Hu Tao]

On Sun, Jun 08, 2014 at 01:10:25PM +0300, Michael S. Tsirkin wrote:
> On Wed, May 14, 2014 at 05:43:15PM +0800, Hu Tao wrote:
> > From: Paolo Bonzini <address@hidden>
> > 
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Hu Tao <address@hidden>
> > ---
> >  hw/i386/pc.c            | 4 +---
> >  include/hw/boards.h     | 6 +++++-
> >  include/sysemu/sysemu.h | 1 +
> >  numa.c                  | 9 +++++++++
> >  4 files changed, 16 insertions(+), 4 deletions(-)
> > 
> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index 3673da8..3778d41 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -1210,9 +1210,7 @@ FWCfgState *pc_memory_init(QEMUMachineInitArgs *args,
> >       * with older qemus that used qemu_ram_alloc().
> >       */
> >      ram = g_malloc(sizeof(*ram));
> > -    memory_region_init_ram(ram, NULL, "pc.ram",
> > -                           below_4g_mem_size + above_4g_mem_size);
> > -    vmstate_register_ram_global(ram);
> > +    memory_region_allocate_system_memory(ram, NULL, "pc.ram", 
> > args->ram_size);
> >      *ram_memory = ram;
> >      ram_below_4g = g_malloc(sizeof(*ram_below_4g));
> >      memory_region_init_alias(ram_below_4g, NULL, "ram-below-4g", ram,
> 
> Better keep below_4g_mem_size + above_4g_mem_size around, this way this
> can be a stand-alone patch.

OK.

Hu