Re: [Qemu-devel] [PATCHv3] migration: catch unknown flags in ram_load

[Juan Quintela]

Peter Lieven <address@hidden> wrote:
> On 10.06.2014 10:45, Amit Shah wrote:
>> On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote:
>>> if a saved vm has unknown flags in the memory data qemu
>>> currently simply ignores this flag and continues which
>>> yields in an unpredictable result.
>>>
>>> this patch catches all unknown flags and
>>> aborts the loading of the vm.
>>>
>>> CC: address@hidden
>>> Signed-off-by: Peter Lieven <address@hidden>
>> Reviewed-by: Amit Shah <address@hidden>
>>
>>> ---
>>> v2->v3: - reworked last case in the if statement
>>>          - added an error_report in case of an unknown flag [David]
>> Thanks.  Would be nice to get an error_report() for the other error
>> conditions, too.  It's not fun to learn migration has failed, w/o any
>> clue of why or where.
>
> Ok, will send v4.
>
> Peter

Thanks very much.