qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback
Date: Tue, 10 Jun 2014 18:29:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 10/06/2014 16:48, Luiz Capitulino ha scritto:
> The s390 restart interrupt is a per-vcpu interrupt, which we really
> don't want to inject on _all_ vcpus. OTOH, we want to inject that
> interrupt on any vcpu - we don't care which one it is. So I'd really
> like an "inject nmi on default cpu" option.

We could define a default CPU for the command. What isn't going to work
is to use the human monitor's "current CPU" concept (set with the cpu
command).

It isn't going to work, but to me it seems like a bug. Why was the NMI command even converted to QAPI if it cannot work? Let's just use monitor_set_cpu from qmp_cpu and call it a day.

The amount of churn that Alexey is going through for this feature is unreasonable.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]