[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/17] target-arm: A64: Emulate the SMC insn
|
From: |
Edgar E. Iglesias |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 15/17] target-arm: A64: Emulate the SMC insn |
|
Date: |
Mon, 16 Jun 2014 08:03:19 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jun 11, 2014 at 04:14:06PM -0500, Greg Bellows wrote:
> On 9 June 2014 10:04, Edgar E. Iglesias <address@hidden> wrote:
>
> > From: "Edgar E. Iglesias" <address@hidden>
> >
> > Signed-off-by: Edgar E. Iglesias <address@hidden>
> > ---
> > target-arm/cpu.h | 1 +
> > target-arm/helper-a64.c | 1 +
> > target-arm/helper.c | 6 ++++++
> > target-arm/helper.h | 1 +
> > target-arm/internals.h | 6 ++++++
> > target-arm/op_helper.c | 27 +++++++++++++++++++++++++++
> > target-arm/translate-a64.c | 10 ++++++++++
> > 7 files changed, 52 insertions(+)
> >
> > diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> > index 679f85f..371f6d2 100644
> > --- a/target-arm/cpu.h
> > +++ b/target-arm/cpu.h
> > @@ -52,6 +52,7 @@
> > #define EXCP_KERNEL_TRAP 9 /* Jumped to kernel code page. */
> > #define EXCP_STREX 10
> > #define EXCP_HVC 11 /* HyperVisor Call */
> > +#define EXCP_SMC 12 /* Secure Monitor Call */
> >
> > #define ARMV7M_EXCP_RESET 1
> > #define ARMV7M_EXCP_NMI 2
> > diff --git a/target-arm/helper-a64.c b/target-arm/helper-a64.c
> > index 974fa66..3894a6f 100644
> > --- a/target-arm/helper-a64.c
> > +++ b/target-arm/helper-a64.c
> > @@ -476,6 +476,7 @@ void aarch64_cpu_do_interrupt(CPUState *cs)
> > case EXCP_UDEF:
> > case EXCP_SWI:
> > case EXCP_HVC:
> > + case EXCP_SMC:
> > env->cp15.esr_el[new_el] = env->exception.syndrome;
> > break;
> > case EXCP_IRQ:
> > diff --git a/target-arm/helper.c b/target-arm/helper.c
> > index 89ccfa8..026c802 100644
> > --- a/target-arm/helper.c
> > +++ b/target-arm/helper.c
> > @@ -3307,6 +3307,12 @@ unsigned int arm_excp_target_el(CPUState *cs,
> > unsigned int excp_idx)
> > case EXCP_HVC:
> > target_el = MAX(target_el, 2);
> > break;
> > + case EXCP_SMC:
> > + target_el = 3;
> > + if (!secure && cur_el == 1 && (env->cp15.hcr_el2 & HCR_TSC)) {
> >
>
> Should we check if EL2 is enabled in this case as it would not make sense
> to target it if it is not.
Hi,
We force hcr_el2 to remain zero when EL2 is unavailable. When EL2
disabled, TSC will never be set.
Cheers,
Edgar
>
>
> > + target_el = 2;
> > + }
> > + break;
> > }
> > return target_el;
> > }
> > diff --git a/target-arm/helper.h b/target-arm/helper.h
> > index fb711be..6c3d84d 100644
> > --- a/target-arm/helper.h
> > +++ b/target-arm/helper.h
> > @@ -51,6 +51,7 @@ DEF_HELPER_3(exception_with_syndrome, void, env, i32,
> > i32)
> > DEF_HELPER_1(wfi, void, env)
> > DEF_HELPER_1(wfe, void, env)
> > DEF_HELPER_2(hvc, void, env, i32)
> > +DEF_HELPER_2(smc, void, env, i32)
> >
> > DEF_HELPER_3(cpsr_write, void, env, i32, i32)
> > DEF_HELPER_1(cpsr_read, i32, env)
> > diff --git a/target-arm/internals.h b/target-arm/internals.h
> > index 2da7a1b..ba269b0 100644
> > --- a/target-arm/internals.h
> > +++ b/target-arm/internals.h
> > @@ -54,6 +54,7 @@ static const char * const excnames[] = {
> > [EXCP_KERNEL_TRAP] = "QEMU intercept of kernel commpage",
> > [EXCP_STREX] = "QEMU intercept of STREX",
> > [EXCP_HVC] = "Hypervisor Call",
> > + [EXCP_SMC] = "Secure Monitor Call",
> > };
> >
> > static inline void arm_log_exception(int idx)
> > @@ -210,6 +211,11 @@ static inline uint32_t syn_aa64_hvc(uint16_t imm16)
> > return (EC_AA64_HVC << ARM_EL_EC_SHIFT) | ARM_EL_IL | imm16;
> > }
> >
> > +static inline uint32_t syn_aa64_smc(uint16_t imm16)
> > +{
> > + return (EC_AA64_SMC << ARM_EL_EC_SHIFT) | ARM_EL_IL | imm16;
> > +}
> > +
> > static inline uint32_t syn_aa32_svc(uint16_t imm16, bool is_thumb)
> > {
> > return (EC_AA32_SVC << ARM_EL_EC_SHIFT) | imm16
> > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
> > index e51cbd6..524dee9 100644
> > --- a/target-arm/op_helper.c
> > +++ b/target-arm/op_helper.c
> > @@ -390,6 +390,33 @@ void HELPER(hvc)(CPUARMState *env, uint32_t syndrome)
> > raise_exception(env, EXCP_HVC);
> > }
> >
> > +void HELPER(smc)(CPUARMState *env, uint32_t syndrome)
> > +{
> > + int cur_el = arm_current_pl(env);
> > + /* FIXME: Use real secure state. */
> > + bool secure = false;
> > + bool smd = env->cp15.scr_el3 & SCR_SMD;
> > + /* On ARMv8 AArch32, SMD only applies to NS mode.
> > + * On ARMv7 SMD only applies to NS mode and only if EL2 is available.
> > + * For ARMv7 non EL2, we force SMD to zero so we don't need to
> > re-check
> > + * the EL2 condition here.
> > + */
> > + bool udef = is_a64(env) ? smd : !secure && smd;
> > +
> > + /* In NS EL1, HCR controlled routing to EL2 has priority over SMD. */
> > + if (!secure && cur_el == 1 && (env->cp15.hcr_el2 & HCR_TSC)) {
> > + udef = false;
> > + }
> > +
> > + /* We've already checked that EL3 exists at translation time. */
> > + if (udef) {
> > + env->exception.syndrome = syn_uncategorized();
> > + raise_exception(env, EXCP_UDEF);
> > + }
> > + env->exception.syndrome = syndrome;
> > + raise_exception(env, EXCP_SMC);
> > +}
> > +
> > void HELPER(exception_return)(CPUARMState *env)
> > {
> > int cur_el = arm_current_pl(env);
> > diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> > index 0319061..1583a00 100644
> > --- a/target-arm/translate-a64.c
> > +++ b/target-arm/translate-a64.c
> > @@ -1452,6 +1452,16 @@ static void disas_exc(DisasContext *s, uint32_t
> > insn)
> > gen_helper_hvc(cpu_env, tmp);
> > tcg_temp_free_i32(tmp);
> > break;
> > + case 3:
> > + if (!arm_dc_feature(s, ARM_FEATURE_EL3) || s->current_pl ==
> > 0) {
> > + unallocated_encoding(s);
> > + break;
> > + }
> > + tmp = tcg_const_i32(syn_aa64_smc(imm16));
> > + gen_a64_set_pc_im(s->pc);
> > + gen_helper_smc(cpu_env, tmp);
> > + tcg_temp_free_i32(tmp);
> > + break;
> > default:
> > unallocated_encoding(s);
> > break;
> > --
> > 1.8.3.2
> >
> >
>
> Otherwise...
>
> Reviewed-by: Greg Bellows <address@hidden>