Re: [Qemu-devel] [PATCH] add input-send-event command

[Gerd Hoffmann]

On Mo, 2014-06-16 at 20:15 -0300, Marcelo Tosatti wrote:
> Which allows specification of absolute/relative, 
> up/down and console parameters.

Looks good overall, only minor nits.  Will wait for acks from qmp guys
before picking into input branch.

> Suggested by Gerd Hoffman.

Huh?  Signed-off missing ...

> +Press left mouse button.
> +
> +-> { "execute": "input-send-event",
> +    "arguments": { "console": 0,
> +                   "events": [ { "type": "btn",
> +                    "data" : { "down": true, "button": "Left" } },
> +                    { "type": "btn",
> +                      "data" : { "down": false, "button": "Left" } } ] } }
> +<- { "return": {} }

Bad example.  Down + up should go as separate commands (so you have a
sync inbetween), otherwise it might happen that the guest doesn't see
the button event at all.

cheers,
  Gerd