Re: [Qemu-devel] [PATCH v5 3/4] virtio-blk-test.c: change pci_nop() to virtblk_init()

[Andreas Färber]

Am 18.06.2014 18:24, schrieb Amos Kong:
> I want to add a new subtest in virtio-blk-test.c, it will start
> guest without network. The original pci_init() did nothing, but
> it's good to reserve a very simple initialization testing.
> 
> Signed-off-by: Amos Kong <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> ---
>  tests/virtio-blk-test.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c
> index d53f875..0fdec01 100644
> --- a/tests/virtio-blk-test.c
> +++ b/tests/virtio-blk-test.c
> @@ -12,9 +12,12 @@
>  #include "libqtest.h"
>  #include "qemu/osdep.h"
>  
> -/* Tests only initialization so far. TODO: Replace with functional tests */

One thing of note here is that this TODO is neither resolved here nor
later in this series. Stefan had originally asked me to add it.

Andreas

> -static void pci_nop(void)
> +/* Tests only initialization */
> +static void virtblk_init(void)
>  {
> +    qtest_start("-drive id=drv0,if=none,file=/dev/null "
> +                "-device virtio-blk-pci,drive=drv0");
> +    qtest_end();
>  }
>  
>  int main(int argc, char **argv)
[snip]

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg