Re: [Qemu-devel] [PATCH 2.1 31/36] qemu-char: introduce qemu_chr_alloc

[Eric Blake]

On 06/18/2014 12:43 AM, Paolo Bonzini wrote:
> The next patch will modify this function to initialize state that is
> common to all backends.
> 
> Reviewed-by: Fam Zheng <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  backends/baum.c       |  2 +-
>  backends/msmouse.c    |  2 +-
>  include/sysemu/char.h |  9 +++++++++
>  qemu-char.c           | 32 +++++++++++++++++++-------------
>  spice-qemu-char.c     |  2 +-
>  ui/console.c          |  2 +-
>  6 files changed, 32 insertions(+), 17 deletions(-)

Missing hw/misc/ivshmem.c:

static int pci_ivshmem_init(PCIDevice *dev)
{
...
        s->eventfd_chr = g_malloc0(s->vectors * sizeof(CharDriverState *));

        qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
ivshmem_read,
                     ivshmem_event, s);


Is that going to matter?  If not,

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature