qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Why I advise against using ivshmem


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] Why I advise against using ivshmem
Date: Sat, 21 Jun 2014 17:34:36 +0800

On Wed, Jun 18, 2014 at 10:57 PM, David Marchand
<address@hidden> wrote:
> On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote:
>>
>> One more thing to add to the list:
>>
>> static void ivshmem_read(void *opaque, const uint8_t * buf, int flags)
>>
>> The "flags" argument should be "size".  Size should be checked before
>> accessing buf.
>
>
> You are welcome to send a fix and I will review it.

I don't plan to send ivshmem patches in the near future because I
don't use or support it.

I thought you were interested in bringing ivshmem up to a level where
distros feel comfortable enabling and supporting it.  Getting there
will require effort from you to audit, clean up, and achieve test
coverage.  That's what a maintainer needs to do in a case like this.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]