Re: [Qemu-devel] [PATCH 2.1 v7 2/3] pc & q35: Add new machine opt max-ram-below-4g

[Don Slutz]

On 06/23/14 10:59, Michael S. Tsirkin wrote:
> On Thu, Jun 19, 2014 at 09:40:25PM -0400, Don Slutz wrote:
> > This is a pc & q35 only machine opt.
...
> >   static void pc_machine_initfn(Object *obj)
> >   {
> > +    PCMachineState *pcms = PC_MACHINE(obj);
> > +
> >       object_property_add(obj, PC_MACHINE_MEMHP_REGION_SIZE, "int",
> >                           pc_machine_get_hotplug_memory_region_size,
> >                           NULL, NULL, NULL, NULL);
> > +    pcms->max_ram_below_4g = 1UL << 32; /* 4G */
> This is a bug: should be 1ULL. Fixed it up locally.

Yes.  Thanks for fixing it.  My 64bit system's gcc:

dcs-xen-54:~/qemu>gcc --version
gcc (GCC) 4.7.2 20120921 (Red Hat 4.7.2-2)
Copyright (C) 2012 Free Software Foundation, Inc.

Gets this wrong generating 32bit code :(

    -Don Slutz

> > +    object_property_add(obj, PC_MACHINE_MAX_RAM_BELOW_4G, "size",
> > +                        pc_machine_get_max_ram_below_4g,
> > +                        pc_machine_set_max_ram_below_4g,
> > +                        NULL, NULL, NULL);
> >   }