[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handl
From: |
Paul Burton |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling |
Date: |
Mon, 23 Jun 2014 23:36:58 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jun 23, 2014 at 11:18:25PM +0100, Paul Burton wrote:
> > Also, VERIFY_READ doesn't seem right for some of the
> > semctl operations which will modify the target_semun.
> >
> > thanks
> > -- PMM
>
> That part I think you're right about, I'll switch to VERIFY_WRITE.
Actually no, I don't think you're right about that afterall. The
argument union itself is never modified. I imagine if it were then it
would be painful in the case of the semctl syscall where the union is
passed directly as an argument, rather than as a pointer as it is for
the ipc syscall.
What may be modified is the data pointed to by the pointers within union
semun. That is already handled by do_semctl & the translate functions it
calls.
/me is not fond of this API...
So anyway, I believe the patch is good as-is.
Thanks,
Paul
signature.asc
Description: Digital signature
- [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Paul Burton, 2014/06/23
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Peter Maydell, 2014/06/23
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Paul Burton, 2014/06/23
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Peter Maydell, 2014/06/23
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Paul Burton, 2014/06/23
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Peter Maydell, 2014/06/23
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Paul Burton, 2014/06/23
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Peter Maydell, 2014/06/24
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Paul Burton, 2014/06/24
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling,
Paul Burton <=
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Peter Maydell, 2014/06/23
- Re: [Qemu-devel] [PATCH] linux-user: fix ipc(SEMCTL, ...) argument handling, Paul Burton, 2014/06/23