qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 4/7] target-arm: Implement pmccntr_sync funct


From: Alistair Francis
Subject: Re: [Qemu-devel] [PATCH v1 4/7] target-arm: Implement pmccntr_sync function
Date: Wed, 25 Jun 2014 08:34:43 +1000

On Wed, Jun 25, 2014 at 1:35 AM, Christopher Covington
<address@hidden> wrote:
> On 06/23/2014 09:12 PM, Alistair Francis wrote:
>> This is used to synchronise the PMCCNTR counter and swap its
>> state between enabled and disabled if required. It must always
>> be called twice, both before and after any logic that could
>> change the state of the PMCCNTR counter.
>
>> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
>> index 31aa09c..0984eda 100644
>> --- a/target-arm/cpu.h
>> +++ b/target-arm/cpu.h
>> @@ -1051,6 +1051,17 @@ static inline bool cp_access_ok(int current_pl,
>>  }
>>
>>  /**
>> + * pmccntr_sync
>> + * @cpu: ARMCPU
>> + *
>> + * Syncronises the counter in the PMCCNTR. This must always be called twice,
>> + * once before any action that might effect the timer and again afterwards.
>> + * The fucntion is used to swap the state of the register if required.
>
> Nit: function

Good catch, will fix

>
> --
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by the Linux Foundation.
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]