Re: [Qemu-devel] [PATCH v3 10/11] target-arm: reorganize gen_aa32_ld/st to prepare for BE32 system emulation

[Peter Maydell]

On 21 June 2014 13:58, Paolo Bonzini <address@hidden> wrote:
> Extract everything to an inline function and simplify DO_GEN_LD/DO_GEN_ST.
>
> Signed-off-by: Paolo Bonzini <address@hidden>

>  DO_GEN_LD(8s, MO_SB)
>  DO_GEN_LD(8u, MO_UB)
>  DO_GEN_LD(16s, MO_SW)
>  DO_GEN_LD(16u, MO_UW)
> -DO_GEN_LD(32u, MO_UL)
>  DO_GEN_ST(8, MO_UB)
>  DO_GEN_ST(16, MO_UW)
> +DO_GEN_LD(32u, MO_UL)
>  DO_GEN_ST(32, MO_UL)

Why move this DO_GEN_LD invocation in amongst the DO_GEN_STs?

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

-- PMM