qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B, drop bs


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B, drop bswap_code
Date: Thu, 26 Jun 2014 18:14:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

Il 26/06/2014 16:53, Peter Maydell ha scritto:
>> This will break running BE32 binaries with "-cpu any"
>> (which sets all the features we know about, including
>> ARM_FEATURE_V7).
>
> Yes, this was on purpose.
I would expect that anybody running BE32 binaries is
probably running them with -cpu any, since it's the
default. So breaking them is a bit harsh...


Yeah, it is.  I guess I can do

static inline bool arm_sctlr_b(CPUARMState *env)
{
    return
#ifndef TARGET_USER_ONLY
      !arm_feature(env, ARM_FEATURE_V7) &&
#endif
      (env->cp15.c1_sys & SCTLR_B) != 0;
}

instead.  Plus a comment of course.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]