[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/3] linux-aio: implement io plug, unplug and
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/3] linux-aio: implement io plug, unplug and flush io queue |
Date: |
Fri, 4 Jul 2014 10:42:15 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jul 04, 2014 at 11:06:41AM +0800, Ming Lei wrote:
> +static int ioq_submit(struct qemu_laio_state *s)
> +{
> + int ret, i = 0;
> + int len = s->io_q.idx;
> +
> + do {
> + ret = io_submit(s->ctx, len, s->io_q.iocbs);
> + } while (i++ < 3 && ret == -EAGAIN);
> +
> + /* empty io queue */
> + s->io_q.idx = 0;
> +
> + if (ret >= 0) {
> + return 0;
> + }
> +
> + for (i = 0; i < len; i++) {
> + struct qemu_laiocb *laiocb =
> + container_of(s->io_q.iocbs[i], struct qemu_laiocb, iocb);
> +
> + laiocb->ret = ret;
> + qemu_laio_process_completion(s, laiocb);
> + }
> + return ret;
> +}
Please see my review of the previous revision. You didn't address my
comments.
Stefan
pgp2Xb72_Ghbf.pgp
Description: PGP signature