Re: [Qemu-devel] [PATCH v2 2/2] block: bump coroutine pool size for drives

[Stefan Hajnoczi]

On Fri, Jul 04, 2014 at 12:36:13PM +0200, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
> > @@ -2093,6 +2093,9 @@ int bdrv_attach_dev(BlockDriverState *bs, void *dev)
> >      }
> bs-> dev = dev;
> >      bdrv_iostatus_reset(bs);
> > +
> > +    /* We're expecting I/O from the device so bump up coroutine pool size 
> > */
> > +    qemu_coroutine_adjust_pool_size(64);
> >      return 0;
> >  }
>  
> > @@ -2112,6 +2115,7 @@ void bdrv_detach_dev(BlockDriverState *bs, void *dev)
> bs-> dev_ops = NULL;
> bs-> dev_opaque = NULL;
> bs-> guest_block_size = 512;
> > +    qemu_coroutine_adjust_pool_size(-64);
> >  }
>  
> >  /* TODO change to return DeviceState * when all users are qdevified */
> 
> Small nitpick. Wouldn't it be better to refactor that constant to a 
> define/enum
> (like in POOL_DEFAULT_SIZE)?

You are right.

Stefan

pgpcVLGyXSMMS.pgp
Description: PGP signature